aleksis/AlekSIS-Core
Watch
8
0
Fork
You've already forked AlekSIS-Core
 0
Code Issues 206 Pull requests 61 Projects Releases 14 Packages 1 Wiki Activity Actions

Fix ICS import #4054

Merged
hansegucker merged 6 commits from 4052-fix-ics-import into master 2026-11-11 22:14:15 +01:00
Conversation 1 Commits 6 Files changed 4 +54 -32
yuha commented 2026-11-05 20:24:00 +01:00
Member
Copy link

Information and screenshots

No further information have been provided.

Checklist

  • tox -e reformat,lint used
  • Changelog updated/No update necessary
  • Documentation (incl. Screenshots) up-to-date
  • Copyright in apps.py and README.rst up-to-date
  • (Unit) tests for new feature/regression tests for bug fixes (only if useful)
  • Adhere to URL scheme
  • Tested with admin account
  • Tested with normal account (based on permissions)

Backend checklist

  • Use permissions for all GraphQL mutations
  • Use query optimizer for all GraphQL queries
  • Don't use inefficient DB queries

Frontend checklist (mandatory with ~"part::frontend")

## Information and screenshots No further information have been provided. ## Checklist - [x] `tox -e reformat,lint` used - [x] Changelog updated/No update necessary - [ ] Documentation (incl. Screenshots) up-to-date - [ ] Copyright in `apps.py` and `README.rst` up-to-date - [ ] (Unit) tests for new feature/regression tests for bug fixes (only if useful) - [ ] Adhere to [URL scheme](https://code.teckids.org/aleksis/aleksis/issues/86) - [ ] Tested with admin account - [ ] Tested with normal account (based on permissions) ## Backend checklist - [ ] Use permissions for all GraphQL mutations - [ ] Use query optimizer for all GraphQL queries - [ ] Don't use inefficient DB queries ## Frontend checklist (mandatory with ~"part::frontend") - [ ] Screenshots are attached (mobile and desktop) - [ ] Tested on mobile, tablet, and desktop sizes - [ ] Adhered to [frontend guidelines](hhttps://code.teckids.org/aleksis/AlekSIS/src/branch/master/project/frontend_guidelines.rst) - [ ] Checked with [Firefox Accessibility Checker](https://firefox-source-docs.mozilla.org/devtools-user/accessibility_inspector/)
Drop inefficient event component type filtering
All checks were successful
CI / lock (push) Successful in 34s
Details
CI / lint (push) Successful in 1m13s
Details
CI / build (push) Successful in 1m18s
Details
CI / test (push) Successful in 3m38s
Details
CI / tests-done (push) Successful in 2s
Details
CI / publish (push) Successful in 10s
Details
1cf65d4c99
Fix ex/rdates handling for imported ics files
All checks were successful
CI / lock (push) Successful in 40s
Details
CI / lint (push) Successful in 1m12s
Details
CI / build (push) Successful in 1m16s
Details
CI / test (push) Successful in 3m37s
Details
CI / tests-done (push) Successful in 2s
Details
CI / publish (push) Successful in 8s
Details
c3a192d367
Add changelog
Some checks failed
CI / lock (push) Successful in 38s
Details
CI / tests-done (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
CI / lint (push) Has been cancelled
Details
b991e4fab9
hansegucker requested changes 2026-11-05 20:26:44 +01:00
aleksis/core/models.py Outdated
@ -4708,1 +4708,4 @@
def get_event_defaults(self, component: Event):
print("GED for", component)
if component.get("exdates"):
print(component.get("exdates"))
hansegucker commented 2026-11-05 20:26:27 +01:00
Owner
Copy link

print bad

print bad
yuha marked this conversation as resolved
aleksis/core/models.py Outdated
@ -4738,3 +4742,2 @@
**details,
"status": str(component.get("status", "")),
"transp": str(component.get("transp", "")),
"status": str(component.status) if component.status else "",
hansegucker commented 2026-11-05 20:26:40 +01:00
Owner
Copy link

Test coverage would be great

Test coverage would be great
yuha marked this conversation as resolved
yuha force-pushed 4052-fix-ics-import from b991e4fab9
Some checks failed
CI / lock (push) Successful in 38s
Details
CI / tests-done (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
CI / lint (push) Has been cancelled
Details
to 3908cc1f4a
Some checks failed
CI / lock (push) Successful in 2m20s
Details
CI / test (push) Failing after 6m50s
Details
CI / build (push) Failing after 6m57s
Details
CI / lint (push) Successful in 7m19s
Details
CI / tests-done (push) Failing after 2s
Details
CI / publish (push) Has been skipped
Details
2026-11-05 20:27:59 +01:00 Compare
Use correct reference to rdates
All checks were successful
CI / lock (push) Successful in 45s
Details
CI / lint (push) Successful in 1m5s
Details
CI / build (push) Successful in 1m26s
Details
CI / test (push) Successful in 4m2s
Details
CI / tests-done (push) Successful in 2s
Details
CI / publish (push) Successful in 10s
Details
79f04ee5bb
Extend ICS-based feed test for r/exdates
Some checks failed
CI / lint (push) Has been cancelled
Details
CI / test (push) Has been cancelled
Details
CI / tests-done (push) Has been cancelled
Details
CI / build (push) Has been cancelled
Details
CI / publish (push) Has been cancelled
Details
CI / lock (push) Has been cancelled
Details
230594ffa3
Reformat
All checks were successful
CI / lock (push) Successful in 28s
Details
CI / lint (push) Successful in 3m10s
Details
CI / build (push) Successful in 3m17s
Details
CI / test (push) Successful in 4m21s
Details
CI / tests-done (push) Successful in 6s
Details
CI / publish (push) Successful in 26s
Details
976c7f8e3b
hansegucker deleted branch 4052-fix-ics-import 2026-11-11 22:14:15 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
hansegucker
Labels
Clear labels   
Security

   
TeX
Needs LaTeX template

  
auto-update
  
board
done

  
board
ready

  
board
todo

  
check
delete-eslint-rc-js

  
check
update-builddeps-package-json

  
check
update-eslint-rc-js

  
check
update-gitignore

  
check
update-merge-request-template

  
check
update-prettier-ignore

  
check
update-pyproject-toml

  
check
update-renovate-json

  
check
update-tox-ini

  
part
backend
 Backend (view code, models, logic, etc.)

  
part
ci

  
part
docs
 Issue or addition to the documentation

  
part
frontend
 Frontend (templates, etc.)

  
part
i18n
 Translation or internationalisation issue

  
part
non-technical
 Non-technical (policy, maintenance, etc.) issue or discussion

  
part
packaging
 Issue concerning the packaging of AlekSIS and components

  
prio
1
 Priority High

  
prio
2
 Priority Medium

  
prio
3
 Priority Low

  
release-mr-5.x
  
size
large

  
size
medium

  
size
small

  
source
customer
 Requested by a customer or affiliated user

  
source
customer::fsmw

  
source
customer::fss

  
source
customer::teckids

  
source
downstream
 Issue or merge request from other projects using AlekSIS or parts of it

  
type
breaking

  
type
bug
 Bug

  
type
feature
 New feature

  
type
refactoring

  
workflow
blocked
 Issue is blocked by another issue

  
workflow
confirmed
 The bug is reproducible and will be fixed

  
workflow
current-todo

  
workflow
discussing
 Needs to be discussed before implementation

  
workflow
new-app
 Requires new AlekSIS app, which has to be created

  
workflow
wontfix
 The bug is not reproducible or the feature was decided against

  
source::aleksolotl
No labels
Security
TeX
auto-update
board
done
board
ready
board
todo
check
delete-eslint-rc-js
check
update-builddeps-package-json
check
update-eslint-rc-js
check
update-gitignore
check
update-merge-request-template
check
update-prettier-ignore
check
update-pyproject-toml
check
update-renovate-json
check
update-tox-ini
part
backend
part
ci
part
docs
part
frontend
part
i18n
part
non-technical
part
packaging
prio
1
prio
2
prio
3
release-mr-5.x
size
large
size
medium
size
small
source
customer
source
customer::fsmw
source
customer::fss
source
customer::teckids
source
downstream
type
breaking
type
bug
type
feature
type
refactoring
workflow
blocked
workflow
confirmed
workflow
current-todo
workflow
discussing
workflow
new-app
workflow
wontfix
source::aleksolotl
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
aleksis/AlekSIS-Core!4054
No description provided.